Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from Exa-Networks:main #37

Open
wants to merge 116 commits into
base: main
Choose a base branch
from
Open

Conversation

pull[bot]
Copy link

@pull pull bot commented Jun 12, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added ⤵️ pull merge-conflict Resolve conflicts manually labels Jun 12, 2024
thomas-mangin and others added 24 commits June 12, 2024 21:36
ensure communities will have the same order whatever order
was presented on the command line.
The code was changed in two patches, one to ensure the ordering
to be consistend when appending to extended communities and not
break the functional testing.

The other change was to merge the feature of add_and_merge into
attribute.add as some code somewhere is using add instead of
add_and_merge and add should do the right thing.

This should be all that is needed to put the issue to rest.
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.2.1...2.2.2)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
So far loopback ips was looking for the corresponding interface by
checking whether the label starts with the desired input.
By providing --label-exact-match it checks whether the label
exactly matches the desired input.

Signed-off-by: Seena Fallah <[email protected]>
healthcheck: add support interface numbering
Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.6.2 to 2024.7.4.
- [Commits](certifi/python-certifi@2024.06.02...2024.07.04)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…4.7.4

Bump certifi from 2024.6.2 to 2024.7.4
  File "./exabgp/./qa/bin/functional", line 155, in collect
    self.message = str(exc)
UnboundLocalError: local variable 'exc' referenced before assignment

Signed-off-by: Donatas Abraitis <[email protected]>
Add missing `exc` exception variable for qa/bin/functional
Some of the open-source implementations already support this feature by default.

https://datatracker.ietf.org/doc/html/draft-walton-bgp-hostname-capability-02

Tested between ExaBGP and FRR:

```
$ vtysh -c 'show bgp neighbor 127.0.0.1 json' | jq '."127.0.0.1".neighborCapabilities.hostName'
{
  "advHostName": "donatas-laptop",
  "advDomainName": "n/a",
  "rcvHostName": "belekas",
  "rcvDomainName": "donatas.net"
}
```

The config is:

```
neighbor 127.0.0.2 {
  router-id 10.10.10.10;
  local-address 127.0.0.1;
  local-as 65001;
  peer-as 65001;
  host-name belekas;
  domain-name donatas.net;
...
}
```

Signed-off-by: Donatas Abraitis <[email protected]>
Let me be disabled until configured explicitly (`host-name`, `domain-name`) in
configuration.

Signed-off-by: Donatas Abraitis <[email protected]>
…ility_by_default

Do not send hostname/domainname (fqdn capability) by default
Without this patch, we mark this capability as Unassigned, instead of really
printing it.

E.g.:

```
15:31:48 290980 outgoing-1      << OPEN version=4 asn=65001 hold_time=180 router_id=192.168.10.252 capabilities=[Multiprotocol(ipv4 unicast), Route Refresh, Extended Message(65535), Graceful Restart Flags 0x4 Time 120 , ASN4(65001), AddPath(receive ipv4 unicast), Enhanced Route Refresh, Unassigned 71, Hostname(donatas-laptop ), Unassigned 75, Unassigned 76]
```

Signed-off-by: Donatas Abraitis <[email protected]>
…lity

Make sure we accept received Hostname capability
@thomas-mangin thomas-mangin force-pushed the main branch 3 times, most recently from c52c374 to 29994c0 Compare October 17, 2024 22:41
following an attempt with #1240 this code provide all the glue code to
make it easier to convert all the api call to json
thomas-mangin and others added 20 commits October 20, 2024 21:29
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5.2.0...v5.3.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…actions/setup-python-5.3.0

Bump actions/setup-python from 5.2.0 to 5.3.0
Reworks the statistics code in a backward compatible way. A new options
called statistics is added and set to true by default.

It shows at every keep-alive sent what are the latest counters for
packet types and others.

The commit is longer than should as some ruff formating got in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⤵️ pull merge-conflict Resolve conflicts manually
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants