forked from Exa-Networks/exabgp
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from Exa-Networks:main #37
Open
pull
wants to merge
116
commits into
lupael:main
Choose a base branch
from
Exa-Networks:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure communities will have the same order whatever order was presented on the command line.
The code was changed in two patches, one to ensure the ordering to be consistend when appending to extended communities and not break the functional testing. The other change was to merge the feature of add_and_merge into attribute.add as some code somewhere is using add instead of add_and_merge and add should do the right thing. This should be all that is needed to put the issue to rest.
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.2.1...2.2.2) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bump urllib3 from 2.2.1 to 2.2.2
So far loopback ips was looking for the corresponding interface by checking whether the label starts with the desired input. By providing --label-exact-match it checks whether the label exactly matches the desired input. Signed-off-by: Seena Fallah <[email protected]>
healthcheck: add support interface numbering
Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.6.2 to 2024.7.4. - [Commits](certifi/python-certifi@2024.06.02...2024.07.04) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…4.7.4 Bump certifi from 2024.6.2 to 2024.7.4
File "./exabgp/./qa/bin/functional", line 155, in collect self.message = str(exc) UnboundLocalError: local variable 'exc' referenced before assignment Signed-off-by: Donatas Abraitis <[email protected]>
Add missing `exc` exception variable for qa/bin/functional
Some of the open-source implementations already support this feature by default. https://datatracker.ietf.org/doc/html/draft-walton-bgp-hostname-capability-02 Tested between ExaBGP and FRR: ``` $ vtysh -c 'show bgp neighbor 127.0.0.1 json' | jq '."127.0.0.1".neighborCapabilities.hostName' { "advHostName": "donatas-laptop", "advDomainName": "n/a", "rcvHostName": "belekas", "rcvDomainName": "donatas.net" } ``` The config is: ``` neighbor 127.0.0.2 { router-id 10.10.10.10; local-address 127.0.0.1; local-as 65001; peer-as 65001; host-name belekas; domain-name donatas.net; ... } ``` Signed-off-by: Donatas Abraitis <[email protected]>
…lity Enable hostname capability (fqdn)
Let me be disabled until configured explicitly (`host-name`, `domain-name`) in configuration. Signed-off-by: Donatas Abraitis <[email protected]>
Signed-off-by: Donatas Abraitis <[email protected]>
…ility_by_default Do not send hostname/domainname (fqdn capability) by default
Signed-off-by: Donatas Abraitis <[email protected]>
Signed-off-by: Donatas Abraitis <[email protected]>
Without this patch, we mark this capability as Unassigned, instead of really printing it. E.g.: ``` 15:31:48 290980 outgoing-1 << OPEN version=4 asn=65001 hold_time=180 router_id=192.168.10.252 capabilities=[Multiprotocol(ipv4 unicast), Route Refresh, Extended Message(65535), Graceful Restart Flags 0x4 Time 120 , ASN4(65001), AddPath(receive ipv4 unicast), Enhanced Route Refresh, Unassigned 71, Hostname(donatas-laptop ), Unassigned 75, Unassigned 76] ``` Signed-off-by: Donatas Abraitis <[email protected]>
…lity Make sure we accept received Hostname capability
thomas-mangin
force-pushed
the
main
branch
3 times, most recently
from
October 17, 2024 22:41
c52c374
to
29994c0
Compare
following an attempt with #1240 this code provide all the glue code to make it easier to convert all the api call to json
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.2.0 to 5.3.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5.2.0...v5.3.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…actions/setup-python-5.3.0 Bump actions/setup-python from 5.2.0 to 5.3.0
Reworks the statistics code in a backward compatible way. A new options called statistics is added and set to true by default. It shows at every keep-alive sent what are the latest counters for packet types and others. The commit is longer than should as some ruff formating got in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )